8000 shell: fixed interpreter builtin arguments not being resolved by helderco · Pull Request #10635 · dagger/dagger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

shell: fixed interpreter builtin arguments not being r 8000 esolved #10635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

shell: fixed interpreter builtin arguments not being resolved #10635

merged 2 commits into from
Jun 24, 2025
+38 −20

Conversation

helderco
Copy link
Contributor
@helderco helderco commented Jun 24, 2025 •
edited
Loading

Reported in:

Test was using echo but it was not properly testing it, so testing with exit.

Example

❯ dagger -M <<'.'
exit_code=$(container | from alpine | with-exec --expect ANY -- sh -c "exit 5" | exit-code)
.echo "Exited with status code $exit_code"
.exit $exit_code
.
▶ connect 0.4s
● loading type definitions 0.4s

● container: Container! 0.0s
$ .from(address: "alpine"): Container! 1.6s CACHED
● .withExec(args: ["sh", "-c", "exit 5"], expect: ANY): Container! 0.2s
▶ .exitCode: Int! 0.3s

Exited with status code 5

✗ echo $?
5

@helderco
shell: fixed interpreter builtin arguments not being resolved
8368a4b 
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
@helderco helderco requested a review from jedevc June 24, 2025 13:32
@helderco
Add change log
8200ba4 
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
@helderco helderco added this to the v0.18.11 milestone Jun 24, 2025
@helderco helderco mentioned this pull request Jun 24, 2025
Closed
@helderco helderco merged commit 36c79f0 into dagger:main Jun 24, 2025
71 of 72 checks passed
@helderco helderco deleted the shell-fix-interp-builtin-arguments branch June 24, 2025 14:11
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedevc jedevc jedevc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.18.11
Development

Successfully merging this pull request may close these issues.
2 participants
@helderco @jedevc
0