[WIP] sdk/java: implementation of moduleTypeDefs #10625
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go SDK now has a moduleTypeDefs method that is dedicated to return types exposed by the module. The `moduleTypeDefs` is similar to `moduleRuntime` but the generated entrypoint only contains the types and not the invocation code. Codegen contains a new flag `--typedefs-only` to only generate the part related to types. Other than this flag, one change in the codegen is a `register` function is created to handle the management of the types. `invoke` function will call `register` when the parent name is empty. And basically when `--typedefs-only` is set, the invoke function is not created but the `register` is and is called instead of `invoke`. Signed-off-by: Yves Brissaud <gh@lgtd.io>
This is an optional new entry point on the module SDK. It's designed to perform the type definition from the module like the actual moduleRuntime when an empty string is passed as argument. If the function doesn't exist, the moduleRuntime is used instead. But this allows to decouple both of them so we can registry types of a module without the runnable module itself because to build it needs the types defined by the module Signed-off-by: Yves Brissaud <gh@lgtd.io>
Use `moduleTypeDefs` instead of `moduleRuntime` if available. Cache the runtime as expected if `moduleTypeDefs` has been called. Signed-off-by: Yves Brissaud <gh@lgtd.io>
Signed-off-by: Yves Brissaud <gh@lgtd.io>
Generate register function for typedefs in a dedicated class so it can be used independently. Signed-off-by: Yves Brissaud <gh@lgtd.io>
Use the container returned by `moduleTypeDefs` to get the module's type definition instead of the runtime container. This container contains an entrypoint with only the type registration function and not the invocation code. Signed-off-by: Yves Brissaud <gh@lgtd.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This needs to be merged after #10584
In the meantime, only the last commits flagged
sdk/javaare really for this PR, the others are from the base branch.This is the java implementation of the new
moduleTypeDefsdefined in #10584This is done by splitting the entry point in two parts, one to register types, on to invoke functions.
This split, at least on the codegen aspect, is interesting even without
moduleTypeDefsas it makes responsibilities clearer.