ignore CA cert automatically installed by OrbStack #10648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles a corner case where the engine tries to install CA certificates after the ca-certificates package is installed but can't because the busybox sh link hasn't been created yet. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
OrbStack will by default automatically put a CA cert in containers, including the dagger engine if the user is running on MacOS w/ OrbStack. This results in the engine seeing a custom CA cert and deciding to automatically install it in every container. While this works it introduces performance overhead for a case that is unlikely to be of any utility. This therefore disables automatic CA cert installation when the only CA cert found is the OrbStack one, keeping the default path case for OrbStack users simpler and more performant. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrbStack will by default automatically put a CA cert in containers,
including the dagger engine if the user is running on MacOS w/ OrbStack.
This results in the engine seeing a custom CA cert and deciding to
automatically install it in every container. While this works it
introduces performance overhead for a case that is unlikely to be of any
utility.
This therefore disables automatic CA cert installation when the only CA
cert found is the OrbStack one, keeping the default path case for
OrbStack users simpler and more performant.
@TomChv noticed this after pulling down this change, so the first commit here also improves some busybox symlink handling in the alpine module.
Discord thread for context: https://discord.com/channels/707636530424053791/1387901998283624654