Various enum member followups #10647
Open
+160
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3256957 to
c5ea7b3
Compare
This could happen on old dagger versions <=v0.18.10 when the enum name was the same as the enum value. Signed-off-by: Justin Chadwell <me@jedevc.com>
We need to resolve these in the typedef structure so that when we do typedef introspection, the default values match the Names, not the OriginalNames. This also lets us simplify decoding the default args significantly (which is what most of this patch updates). Signed-off-by: Justin Chadwell <me@jedevc.com>
c5ea7b3 to
1270c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #9518.
There was an issue where old dagger versions would create an invalid typedef when the enum
nameequaled the enumvalueReported by @nipuna-perera in discord.
There was an issue where
--helpfor enum default values was incorrect.Reported in 🐞 Cannot pass string values for Enum types with CLI in v0.18.11 #10644.