8000 feat(go): allow multiline pragmas by jedevc · Pull Request #10594 · dagger/dagger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(go): allow multiline pragmas #10594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

feat(go): allow multiline pragmas #10594

merged 3 commits into from
Jun 23, 2025

Conversation

jedevc
Copy link
Member
@jedevc jedevc commented Jun 16, 2025

Fix for #8383.

@jedevc jedevc force-pushed the multiline-pragma branch 2 times, most recently from 4eaaeaa to b397a0c Compare June 16, 2025 14:30
@jedevc jedevc requested review from helderco June 16, 2025 14:54
@nipuna-perera
Copy link
Contributor

Would it be possible to support backticks instead of " for multi line? It's a bit awkward to use " for multiline because that's not exactly valid or idiomatic go.

@jedevc
Copy link
Member Author
jedevc commented Jun 16, 2025

The parser for the pragma values is using JSON (just like it does today) - so you can't have multi-line strings.

Allowing multi-line strings and everything like that isn't quite in scope right now, I just wanted to make sure we could support multi-line arrays (since those are really horrible).

@nipuna-perera

This comment was marked as resolved.

Sign in to view
@jedevc jedevc added needs/changelog Pull requests that require a changelog entry needs/docs Pull requests that require a docs change area/sdk/go labels Jun 16, 2025
@jedevc jedevc requested review from a team as code owners June 16, 2025 16:33
nipuna-perera
nipuna-perera reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor
@nipuna-perera nipuna-perera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

helderco
helderco approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor
@helderco helderco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jedevc jedevc force-pushed the multiline-pragma branch from 2bc4217 to 98f5021 Compare June 17, 2025 13:46
@jedevc jedevc added this to the v0.18.11 milestone Jun 23, 2025
@jedevc jedevc force-pushed the multiline-pragma branch from 98f5021 to 5f06d5f Compare June 23, 2025 11:22
jedevc added 3 commits June 23, 2025 13:34
@jedevc
feat(go): allow multiline pragmas
1cfbdb0 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc
docs: mention that ignore pragmas can be split to multiple lines
afdee52 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc
chore: add CHANGELOG
842ef5c 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc force-pushed the multiline-pragma branch from 5f06d5f to 842ef5c Compare June 23, 2025 12:34
@jedevc jedevc merged commit 54e5848 into dagger:main Jun 23, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nipuna-perera nipuna-perera nipuna-perera left review comments

@helderco helderco Awaiting requested review from helderco

Assignees
No one assigned
Labels
area/sdk/go needs/changelog Pull requests that require a changelog entry needs/docs Pull requests that require a docs change
Projects
None yet
Milestone
v0.18.11
Development

Successfully merging this pull request may close these issues.
3 participants
@jedevc @nipuna-perera @helderco
0