chore: convert withFile to dagop #10569
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8e6133 to
94be28c
Compare
This is no longer allowed, since we'd require a dagop for this - we can instead just re-call `withExec` through the server to get it working. Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
We need to make sure that we pass this into the top-most context, since it can be used during `Load`. Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
This is useful, so now we can use dag.Select over it. Signed-off-by: Justin Chadwell <me@jedevc.com>
We already have this implemented through the Server function. Don't really know why it needed to be duplicated (seems like a past-me brainfart). Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Various improvements, including: - Allow configuring the entire buildkit cache map, instead of just the cache key - Track the cause context.Context, useful for tracing (this is ideally where spans should be attached to) - Fallback to getting client metadata using the weird hacky session manager thing that buildkit has. This is annoying, but if we don't do this, it's very easy to end up in strange edge merging bugs (and I don't want to remove that as part of this work). Signed-off-by: Justin Chadwell <me@jedevc.com>
This helps to pass JSON-serializable objects through the schema easily. It's not a directly exposed type, just a helper. Signed-off-by: Justin Chadwell <me@jedevc.com>
Reimplement it *entirely* inside of dagop! There are a few different things components that this interacts with that makes it a bit tricky to integrate. - `asService` had a dependency on `ExecOp` - this needed to be entirely removed, which is a real pain for the legacy case, so we do an ID inspection. - `ExecError` also depended on using `ExecOp`, so this needed reworking, it's now a `RichError` type which can be used for *any* sort of live ref debugging. - Module calls, these for now still depend on using `withExec` in a super hacky way, but in the future, this should hopefully be removed as we cache module calls natively in dagql caching. Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Alex Couture-Beil <alex@mofo.ca>
Regression test for case where mixing services and dagops would break with an "open /.dagger_meta_mount: no such file or directory" error. Signed-off-by: Alex Couture-Beil <alex@mofo.ca>
Explicitly return ErrNoCommand when meta is not set, rather than having "empty reference" returned. This is to preserve existing functionality. Signed-off-by: Alex Couture-Beil <alex@mofo.ca>
1124724 to
cf87763
Compare
TUI no longer has a checkmark in it, use a dot instead. Signed-off-by: Alex Couture-Beil <alex@mofo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.