8000 chore: rename sweep option to sweepSize by jedevc · Pull Request #10560 · dagger/dagger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: rename sweep option to sweepSize #10560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

chore: rename sweep option to sweepSize #10560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Breaking-20250623-180015.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Breaking
body: |
Changed incorrect `sweep` option name to `sweepSize`
time: 2025-06-23T18:00:15.18961196+01:00
custom:
Author: jedevc
PR: "10560"
4 changes: 2 additions & 2 deletions docs/static/reference/engine.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"$ref": "# 8000 /$defs/DiskSpace",
"description": "MinFreeSpace is the target amount of free disk space the garbage collector will attempt to leave. However, it will never let the available space fall below ReservedSpace."
},
"sweep": {
"sweepSize": {
"$ref": "#/$defs/DiskSpace",
"description": "SweepSize is the minimum amount of space to sweep during a single gc pass. Either an absolute number of bytes, or a percentage of the \"allowed space\" between reserved and max."
},
Expand Down Expand Up @@ -123,7 +123,7 @@
"$ref": "#/$defs/DiskSpace",
"description": "MinFreeSpace is the target amount of free disk space the garbage collector will attempt to leave. However, it will never let the available space fall below ReservedSpace."
},
"sweep": {
"sweepSize": {
"$ref": "#/$defs/DiskSpace",
"description": "SweepSize is the minimum amount of space to sweep during a single gc pass. Either an absolute number of bytes, or a percentage of the \"allowed space\" between reserved and max."
}
Expand Down
2 changes: 1 addition & 1 deletion engine/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ type GCSpace struct {
// SweepSize is the minimum amount of space to sweep during a single gc pass.
// Either an absolute number of bytes, or a percentage of the "allowed
// space" between reserved and max.
SweepSize DiskSpace `json:"sweep,omitempty"`
SweepSize DiskSpace `json:"sweepSize,omitempty"`
}

func (space *GCSpace) IsUnset() bool {
Expand Down
0