[23-01-31] dain.py #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chs98412
reviewed
Jan 30, 2023
| @@ -1 +1,2 @@ | |||
|
|
|||
| def solution(nums): | |||
| return min(len(nums) / 2, len(set(nums))) | |||
There was a problem hiding this comment.
min은 생각 못했는데 if else보다 오히려 가독성 좋은거 같아요!
Lee-DoHa
reviewed
Jan 30, 2023
| @@ -1 +1,2 @@ | |||
|
|
|||
| def solution(nums): | |||
| return min(len(nums) / 2, len(set(nums))) | |||
There was a problem hiding this comment.
min을 사용하면 시간복잡도 O(n)이 추가되긴 해요 하지만 가독성은 베스트
There was a problem hiding this comment.
위 코드에서 min()은 O(n)이아니라 O(2)의 상수시간!
그보다는 set(nums)로 set을 생성할 때 set의 길이만큼의 시간복잡도를 갖는다!😮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
N/2중 더 작은 것이 정답(다음)가 들어갈 차례면pop()append()ISSUE NUMBER