feat(proto): added hub and rdk x/sequencer #1136
Conversation
There was a problem hiding this comment.
mistake? already included in dymensionxyz/dymension/sequencer
or it's the RDK proto? if so let's move it to ``dymensionxyz/dymension-rdk`?
There was a problem hiding this comment.
not a mistake, i followed the proto package prefix which is rollapp.sequencers.types for this file. i believe the folder layout must repeat the package name.
| "github.com/stretchr/testify/require" | ||
|
|
||
| protoutils "github.com/dymensionxyz/dymint/utils/proto" | ||
| cosmosseq "github.com/dymensionxyz/dymint/utils/proto/test_data/cosmos_proto" |
There was a problem hiding this comment.
why u need it copied to test_data? can't u use types/pb/... directly?
There was a problem hiding this comment.
the idea was to have two unchangeable packages having the same types (Sequencer in our case) but different proto.Any impls (with gogo and cosmos) so i can test their compatibility. it's just test data, i don't want to involve "real" types here.
PR Standards
Close #1083
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: