feat: keplr lifecycle notifs #1688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Fix TransactionMemos so that they make sense as well as add a transfer memo
- consolidate logic from lifecycle method selectors into their own standalone selector. This is now shared between lifecycle method and these keplr lifecycle dialogs
- add keplr lifecycle dialogs and notifications
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tyleroooo
reviewed
May 6, 2025
|
|
||
| await Promise.all( | ||
| reclaimableChildSubaccounts.map(({ subaccountNumber, usdcBalance }) => | ||
| transferBetweenSubaccounts( |
There was a problem hiding this comment.
kinda would be nice to move this to account transaction supervisor because I hate useSubaccounts but I guess this is fine for now.
tyleroooo
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.