8000 fix: faster, nonblocking conditional order cancels by tyleroooo · Pull Request #1653 · dydxprotocol/v4-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: faster, nonblocking conditional order cancels #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025

Conversation

tyleroooo
Copy link
Contributor

No description provided.

@tyleroooo tyleroooo requested a review from a team as a code owner April 25, 2025 16:39
Copy link
vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10000
Name Status Preview Comments Updated (UTC)
v4-staging 🛑 Canceled (Inspect) Apr 25, 2025 6:19pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 6:19pm

return;
}

Promise.all(
reclaimableChildSubaccounts.map(async (childSubaccountFunds) => {
const subaccountString = `${childSubaccountFunds.subaccountNumber}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer .toString()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair fair, changing

@tyleroooo tyleroooo enabled auto-merge (squash) April 25, 2025 18:17
@tyleroooo tyleroooo merged commit 350b7ae into main Apr 25, 2025
9 checks passed
6811
@tyleroooo tyleroooo deleted the tu/locked-cancel-triggers branch April 25, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0