8000 feat: use cuer for QR by jaredvu · Pull Request #1642 · dydxprotocol/v4-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: use cuer for QR #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

feat: use cuer for QR #1642

merged 4 commits into from
Apr 22, 2025

Conversation

jaredvu
Copy link
Contributor
@jaredvu jaredvu commented Apr 22, 2025 •
edited
Loading
Screenshot 2025-04-22 at 10 30 12 AM Screenshot 2025-04-22 at 10 30 20 AM Screenshot 2025-04-22 at 10 30 29 AM Screenshot 2025-04-21 at 6 15 03 PM

@jaredvu jaredvu requested a review from a team as a code owner April 22, 2025 01:15
@vercel Vercel
Copy link
vercel bot commented Apr 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 5:32pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 5:32pm

tyleroooo
tyleroooo approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor
@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works, seems sane to me. This stuff is currently mostly broken I think

@tyleroooo
Copy link
Contributor

the share dialog is still very broken

@tyleroooo
Copy link
Contributor

dunno what the QR code is even for

@jaredvu jaredvu merged commit ce5eaa7 into main Apr 22, 2025
10 checks passed
@jaredvu jaredvu deleted the jv/cuer branch April 22, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleroooo tyleroooo tyleroooo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredvu @tyleroooo
0