8000 feat: update deposit ui receipts and routeoptions by jaredvu · Pull Request #1640 · dydxprotocol/v4-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: update deposit ui receipts and routeoptions #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 21, 2025
Merged

Conversation

jaredvu
Copy link
Contributor
@jaredvu jaredvu commented Apr 21, 2025
Screenshot 2025-04-21 at 1 42 50 PM

@jaredvu jaredvu requested a review from a team as a code owner April 21, 2025 20:42
Copy link
vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 9:26pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 9:26pm

Copy link
Contributor
@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved w/ suggestion

* @description The fee for the source chain to fulfill the go fast route.
* @note The fee is hardcoded on Skip's end.
*/
export const SKIP_GO_FAST_SOURCE_FEE_MAP: Record<string, number> = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we strongly type this so that if we add another supported chain we remember to add here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fast follow with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0