10000 feat(bonsai-core): reclaimChildSubaccountFunds lifecycle by jaredvu · Pull Request #1572 · dydxprotocol/v4-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(bonsai-core): reclaimChildSubaccountFunds lifecycle #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 25, 2025
Merged

feat(bonsai-core): reclaimChildSubaccountFunds lifecycle #1572

merged 19 commits into from
Apr 25, 2025

Conversation

jaredvu
Copy link
Contributor
@jaredvu jaredvu commented Mar 14, 2025
  • add isParentSubaccount helper
  • add new memo for reclaim
  • add lifecycle method to reclaim funds from childSubaccounts that have no positions and no open orders

@jaredvu jaredvu requested a review from a team as a code owner March 14, 2025 19:11
@linear Linear
Copy link
linear bot commented Mar 14, 2025

TRA-942 reclaimUnutilizedFundsFromChildSubaccounts()

@vercel Vercel
Copy link
vercel bot commented Mar 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 5:28pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 5:28pm

tyleroooo
tyleroooo previously approved these changes Apr 25, 2025
View reviewed changes
Base automatically changed from jared/tra-946-canceltriggerorderswithclosedorflippedpositions to main April 25, 2025 16:19
@tyleroooo tyleroooo dismissed their stale review April 25, 2025 16:19

The base branch was changed.

@tyleroooo tyleroooo merged commit 998e93e into main Apr 25, 2025
10 checks passed
@tyleroooo tyleroooo deleted the jared/tra-942-reclaimunutilizedfundsfromchildsubaccounts branch April 25, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleroooo tyleroooo tyleroooo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredvu @tyleroooo
0