8000 bump the minimum version of cmake by inthehack · Pull Request #314 · dvidelabs/flatcc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bump the minimum version of cmake #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump the minimum version of cmake #314

wants to merge 1 commit into from

Conversation

inthehack
Copy link

This commit bumps the minimum version of CMake in CMakeLists.txt files.

The version of CMake in Ubuntu LTS is 3.28 and in CentOS is 3.26. Then, the version of CMake is set to 3.25 arbitrary.

@inthehack
bump the minimum version of cmake
035e0cd 
This commit bumps the minimum version of CMake in CMakeLists.txt
files.

The version of CMake in Ubuntu LTS is 3.28 and in CentOS is 3.26. Then,
the version of CMake is set to 3.25 arbitrary.
@mikkelfj
Copy link
Contributor
mikkelfj commented Mar 11, 2025 •
edited
Loading

Sorry for the late answer. There is a slow long term plan to bump CMake, but it was indeed tied up to Ubuntu LTS and the desire to support older Ubuntu.

@bjornharrtell We are just right now bumping to a more recent LTS in CI build, but other users might not.

Therefore I do not currently have a clear view on what is the safe CMake version, but there are some issues where this has been discussed in the past. But I do recognize that the current CMake version is outdated.

@mikkelfj
Copy link
Contributor

Also note that AppVeyor currently fails this PR due it running: cmake version 3.16.2
We also need to figure out a plan for migrating Windows builds to GH actions, but there is a lack of support for older MSVC compilers here.

@mikkelfj
Copy link
Contributor

BTW: I am now getting some strange warnings in CMake on MacOS related to add_custom_command that likely needs to be dealt with.

CMake Warning (dev) at test/monster_test_cpp/CMakeLists.txt:13 (add_custom_command):
The following keywords are not supported when using
add_custom_command(TARGET): DEPENDS.

CMake Warning (dev) at test/monster_test/CMakeLists.txt:10 (add_custom_command):
Exactly one of PRE_BUILD, PRE_LINK, or POST_BUILD must be given. Assuming
POST_BUILD to preserve backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inthehack @mikkelfj
0