-
Notifications
You must be signed in to change notification settings - Fork 0
add orientation utils #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dhvanipa
merged 8 commits into
vdrg/refactor-orientation
from
dhvanipa/refactor-orientation
May 21, 2025
Merged
add orientation utils #281
dhvanipa
merged 8 commits into
vdrg/refactor-orientation
from
dhvanipa/refactor-orientation
May 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhvanipa
commented
May 21, 2025
{ | ||
name: "Bed", | ||
mass: 13500000000000000n, | ||
supportedOrientations: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a limitation from our client where the bed only supports these 2
vdrg
approved these changes
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
vdrg
added a commit
that referenced
this pull request
May 21, 2025
* Use orientation * Adapt systems and tests to use orientation * Add orientation tests, fix applyOrientation * Fix reflections table, fix orientation tests * Move orientation functions to OrientationLib * add orientation utils (#281) * add types and utils for orientation * add orientation test * add encode orientation util and tests * fix ts doesnt know size * add getDirection util * add orientation to other placeables * fix bed only supports 2 * fix bed pos * Adapt tests * Add test for build with orientation * Add test for mining multi voxel object with orientation --------- Co-authored-by: Dhvani Patel <dhvani.patel@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.