Upgrade to support light/dark theme code highlighting #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of rouge has both a github light theme and a github dark theme. With this commit, code highlighting will now correctly use whichever theme is set in the frontmatter of a page or in _config.yml. This also supports when the theme is set to an auto theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily adds support for code highlighting to be correctly styled for
rouge's new github light and dark themes. This also supports auto mode, so it can correctly be styled based on whatever mode the system is set to!This also updates the node dependencies (including primer) and uses the new
jekyll-github-metadata.Last but not least, this bumps the projects version to
0.10.0.