make no-mouse default true #419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the option `--no-mouse` `true` by default. Rationale: users of `gdu` would be used to `ncdu` where text selection is ON by default. If I am using gdu on a remote server, my use of text-selection is even more obvious. Ideally the option `--no-mouse` could be turned as `--mouse` with "false" as default. Putting this PR out there to see if it is OK.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 83.50% 83.50%
=======================================
Files 46 46
Lines 4408 4408
=======================================
Hits 3681 3681
Misses 655 655
Partials 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix the warnings from staticheck based on the following. silencing the strings.Title as there is lint comment previously present $ staticcheck ./... report/export.go:70:9: error strings should not be capitalized (ST1005) report/export.go:75:9: error strings should not be capitalized (ST1005) report/import.go:31:15: error strings should not be capitalized (ST1005) report/import.go:36:15: error strings should not be capitalized (ST1005) report/import.go:50:15: error strings should not be capitalized (ST1005) report/import.go:54:15: error strings should not be capitalized (ST1005) tui/actions.go:195:3: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019) tui/marked.go:58:6: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019)
|
accidentally committed multiple changes to same branch. closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the option
--no-mousetrueby default.Rationale: users of
gduwould be used toncduwhere text selection is ON by default. If I am using gdu on a remote server, my use of text-selection is even more obvious.Ideally the option
--no-mousecould be turned as--mousewith "false" as default.Putting this PR out there to see if it is OK.