8000 Add :duct/regex reader tag by iku000888 · Pull Request #21 · duct-framework/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add :duct/regex reader tag #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add :duct/regex reader tag #21

wants to merge 1 commit into from

Conversation

iku000888
Copy link

There are libs(e.g. https://github.com/r0man/ring-cors) that require regex patterns to be passed in, and it would be great if I can specify e.g. #"some-allowed-origin" directly 8000 in the config edn file.
This however did not work because it is not part of the eden spec.

This PR is the next thing I tried in my project and was pretty happy about it. Would it make sense to have this in duct/core?

weavejester
weavejester requested changes Mar 28, 2019
View reviewed changes
Copy link
Contributor
@weavejester weavejester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, but I'll need to think about it.

You know that custom reader tags can be specified, right?

src/duct/core.clj Outdated
@@ -110,7 +111,8 @@
(merge
{'duct/env env/env
'duct/include (make-include readers)
'duct/resource resource}
'duct/resource resource
'duct/regex #(Pattern/compile %)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be changed to re-compile?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean re-pattern?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@iku000888 iku000888 force-pushed the feature/regex-reader-tag branch from fd56e7f to dab4953 Compare March 29, 2019 00:35
@iku000888
Copy link
Author

You know that custom reader tags can be specified, right?

Yes and that is what I do right now and works great & happy with that, so it is totally up to you ;)

@iku000888 iku000888 force-pushed the feature/regex-reader-tag branch from dab4953 to 6ccb1ac Compare March 29, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weavejester weavejester weavejester requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iku000888 @weavejester
0