Fix autoloading required extension for data_path #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently requires: `httpfs` extension to be build together with `ducklake`, and then: LOCAL_EXTENSION_REPO='build/release/repository' ./build/release/test/unittest --test-dir . test/sql/autoloading/autoload_data_path.test
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will, without this PR, do not autoload httpfs, and eventually use the folder s3://some-bucket using the default folder when
httpfsis missing OR remote bucket whenhttpfsis present.This PR makes so that in either case an initialized DuckLake has to be usable, possible paths are:
As a consequence of this, secrets are also loaded, but there is no actual test the path is actually reachable (say networking or mismatched secrets). For that an insert or scan is actually needed (keeping same behaviour as now, so initialize perform no network request to
data_path).Test shows what are the possibilities, to be able to run the test (but for the last line), the following can be used
To manage also the last like,
httpfsextension is needed to be built (but not linked) together with ducklake.