Skip encodings and spatial extensions on PRs #17775
Merged
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8484508 to
4e7cf7b
Compare
4e7cf7b to
c81e8bd
Compare
c81e8bd to
009a6b3
Compare
009a6b3 to
565330c
Compare
|
Sounds good to me, Im planning on getting spatial back on nightly reassert CI anyways, and that should probably be enough |
|
Tested opening a token PR against the relevant branch on my fork: https://github.com/carlopi/duckdb/actions/runs/15425200409/job/43410241563 and https://github.com/carlopi/duckdb/actions/runs/15425200390/job/43410241521, to be reviewed once they pass. New runs at https://github.com/carlopi/duckdb/actions/runs/15427935770 and https://github.com/carlopi/duckdb/actions/runs/15427935769 |
|
Tests worked as intended (after a couple of fixes :) ), this should have no impact on nigthly / release binaries, but be somewhat lighter on PRs. |
Add infra so that a subset of extensions can be tested on each PR, that should speed up CI times with limited risks
565330c to
ae13362
Compare
|
Test failure is networking, and behaviour added here is not tested by this CI. |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
Add `FileBufferType::EXTERNAL_FILE` and add to same queue as `FileBufferType::BLOCK` (duckdb/duckdb#17771) Skip encodings and spatial extensions on PRs (duckdb/duckdb#17775) [chore] Avoid caching msys artifacts on PRs (duckdb/duckdb#17777)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
Add `FileBufferType::EXTERNAL_FILE` and add to same queue as `FileBufferType::BLOCK` (duckdb/duckdb#17771) Skip encodings and spatial extensions on PRs (duckdb/duckdb#17775) [chore] Avoid caching msys artifacts on PRs (duckdb/duckdb#17777) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Jun 13, 2025
Mytherin
added a commit
that referenced
this pull request
Jun 13, 2025
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 13, 2025
bump spatial (duckdb/duckdb#17920) bump azure, aws and httpfs (duckdb/duckdb#17919) Make sure distance is always an int when doing version bumps in setup.py (duckdb/duckdb#17918) Fixup duckdb/duckdb#17775, correct boolean logic (duckdb/duckdb#17912) http_log.test: solve non-determinism at the test level (duckdb/duckdb#17914) Throw error when using dbgen on non-DuckDB databases
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 13, 2025
bump spatial (duckdb/duckdb#17920) bump azure, aws and httpfs (duckdb/duckdb#17919) Make sure distance is always an int when doing version bumps in setup.py (duckdb/duckdb#17918) Fixup duckdb/duckdb#17775, correct boolean logic (duckdb/duckdb#17912) http_log.test: solve non-determinism at the test level (duckdb/duckdb#17914) Throw error when using dbgen on non-DuckDB databases Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
staticlibs
pushed a commit
to staticlibs/duckdb
that referenced
this pull request
Jun 18, 2025
This is a cherry-pick of the PR duckdb#17912 from `v1.3-ossivalis` branch. Fixup duckdb#17775, correct boolean logic
Mytherin
added a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add infra so that a subset of extensions can be tested on each PR, that should speed up CI times with limited risks.
Currently skips
encodingsandspatialon PRs. Which extensions is up for discussions, I would be for expanding even more, given most extensions are not actually impacting CI surface.I would like to see whether this actually works (minor implementations details migth be off), then we can discuss.
This could also be paired with other ideas to improve PR process, like having a tag "extra tests" that opt-in to the full set of tests, but this is worth having also in isolation I think.