8000 Fix python nightly build by Tishj · Pull Request #17515 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix python nightly build #17515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Fix python nightly build #17515

merged 2 commits into from
May 16, 2025
+1 −4

Conversation

Tishj
Copy link
Contributor
@Tishj Tishj commented May 16, 2025 •
edited
Loading

Revert #17443

They (setuptool_scm) have not fixed their problem, all they've done is upgrade the warning into an error, so we won't use those newer versions until they fix it 👍

@Tishj Tishj force-pushed the fix_python_nightly_build branch from a5c5bee to 13db15b Compare May 16, 2025 09:09
@Tishj Tishj changed the base branch from main to v1.3-ossivalis May 16, 2025 09:09
@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 16, 2025 09:10
@Tishj Tishj marked this pull request as ready for review May 16, 2025 09:21
@hmeriann
Copy link
Contributor

Thanks! And for the explanation

carlopi
carlopi approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@carlopi carlopi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround, looks about right, go.

@hannes hannes merged commit f027a66 into duckdb:v1.3-ossivalis May 16, 2025
15 checks passed
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 21, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@feb4ed8
7763dca 
Use Catalog::TryAutoLoad for encodings extension (duckdb/duckdb#17520)
Fix python nightly build (duckdb/duckdb#17515)
Fix encodings (duckdb/duckdb#17514)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 21, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@feb4ed8
ff4b87e 
Use Catalog::TryAutoLoad for encodings extension (duckdb/duckdb#17520)
Fix python nightly build (duckdb/duckdb#17515)
Fix encodings (duckdb/duckdb#17514)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 21, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@feb4ed8
9dfd876 
Use Catalog::TryAutoLoad for encodings extension (duckdb/duckdb#17520)
Fix python nightly build (duckdb/duckdb#17515)
Fix encodings (duckdb/duckdb#17514)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 23, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@feb4ed8
ab87326 
Use Catalog::TryAutoLoad for encodings extension (duckdb/duckdb#17520)
Fix python nightly build (duckdb/duckdb#17515)
Fix encodings (duckdb/duckdb#17514)
@icp1994
Copy link
icp1994 commented Jun 1, 2025

Is there no way around it? https://pypi.org/project/setuptools-scm/8.0.1/ was released on Sep 20, 2023. Many distros have long since updated to this new major version. So it's not possible to build the python bindings for duckdb v1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlopi carlopi carlopi approved these changes

Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tishj @hmeriann @icp1994 @carlopi @hannes
0