unittest: improve detection of whether or not we can run --force-restart tests
#17419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests automatically when there are, avoiding us requiring many skip_reload flags in the test suite
…les reloading, and remove skip_reload from many tests
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
unittest: improve detection of whether or not we can run `--force-restart` tests (duckdb/duckdb#17419)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
unittest: improve detection of whether or not we can run `--force-restart` tests (duckdb/duckdb#17419)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
unittest: improve detection of whether or not we can run `--force-restart` tests (duckdb/duckdb#17419)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
unittest: improve detection of whether or not we can run `--force-restart` tests (duckdb/duckdb#17419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--force-restarttests are useful to stress test database restarts by restarting in between each statement - but we cannot always restart since we have transient state (e.g. attached databases, prepared statements, etc). Restarting will then lead to failing the test. For tests that have this transient state we have been accumulating a lot ofrequire skip_reloadflags. This is undesirable since this often breaks CI only in the final stages of a PR (at which point these skips are added).This PR instead improves detection on when we can restart, allowing almost all of the
require skip_reloadflags in tests to be removed. In particular:TEMPORARYstructures (tables, views, etc) (new)We introduce new syntax for specifying seeds in the tests:
This syntax sets the seed, and also disables the force restart tests.