If distinct count from stats is 0, do not use it in Join Order Optimizer #17466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
If distinct count from stats is 0, do not use it in Join Order Optimizer (duckdb/duckdb#17466) [Python Dev] Guard against python exceptions when interacting with the `currentframe` object (duckdb/duckdb#17490)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
If distinct count from stats is 0, do not use it in Join Order Optimizer (duckdb/duckdb#17466) [Python Dev] Guard against python exceptions when interacting with the `currentframe` object (duckdb/duckdb#17490)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
If distinct count from stats is 0, do not use it in Join Order Optimizer (duckdb/duckdb#17466) [Python Dev] Guard against python exceptions when interacting with the `currentframe` object (duckdb/duckdb#17490)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes bad join orderings when reading from scanners that provide 0 as a distinct count.
If a table truly has a distinct count of 0, then the cardinality is also 0, so falling back to the cardinality count is fine in this case.