[Arrow] Implement support to consuming and producing Decimal 32 and 64. #17314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM |
carlopi
added a commit
to carlopi/duckdb-wasm
that referenced
this pull request
May 6, 2025
carlopi
added a commit
to duckdb/duckdb-wasm
that referenced
this pull request
May 6, 2025
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Arrow] Implement support to consuming and producing Decimal 32 and 64. (duckdb/duckdb#17314)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Arrow] Implement support to consuming and producing Decimal 32 and 64. (duckdb/duckdb#17314)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
[Arrow] Implement support to consuming and producing Decimal 32 and 64. (duckdb/duckdb#17314)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
[Arrow] Implement support to consuming and producing Decimal 32 and 64. (duckdb/duckdb#17314)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main points to note are that REE and filters are not yet implemented in the PyArrow engine for both
decimal32anddecimal64. Therefore, the related REE tests have been removed, and filters for these decimal types are not pushed down.Fix: https://github.com/duckdblabs/duckdb-internal/issues/3108
Fix: https://github.com/duckdblabs/voltron-data/issues/36