Return invalid BufferHandle upon loading a destroyed BlockHandle
#17249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curiosity: what was the exact failure message(s) that might have been returned? |
|
@carlopi |
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Return invalid `BufferHandle` upon loading a destroyed `BlockHandle` (duckdb/duckdb#17249)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Return invalid `BufferHandle` upon loading a destroyed `BlockHandle` (duckdb/duckdb#17249)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Return invalid `BufferHandle` upon loading a destroyed `BlockHandle` (duckdb/duckdb#17249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks can be destroyed at any time if they are flagged with
DestroyBufferUpon::EVICTIONwhen they are not pinned. If we try to pin them later, they should return an invalidBufferHandleinstead of running into anInternalException.I found this myself while playing around when doing some Parquet joins with low memory settings.