Notify nightly build status #17108
Merged
Notify nightly build status #17108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the NotifyExternalRepositories.yml so it could not trigger Vendor.yml if builds hadn't succeeded
carlopi
approved these changes
Apr 16, 2025
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Strict UUID cast (duckdb/duckdb#17138) Notify nightly build status (duckdb/duckdb#17108)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Strict UUID cast (duckdb/duckdb#17138) Notify nightly build status (duckdb/duckdb#17108)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Strict UUID cast (duckdb/duckdb#17138) Notify nightly build status (duckdb/duckdb#17108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to trigger the
NightlyBuildsStatus.ymlin the end of theInvokeCI.ymlrun.There is a
NotifyExternalRepositories.ymlworkflow for triggering workflow run on the external repos - we just need to pass there all the inputs needed byNightlyBuildsStatus.ymlrun (branch name, event name, should the status report be published or not).The
NotifyExternalRepositories.ymltriggers two workflows: duckdb-odbc/.github/workflows/Vendor.ymland duckdb-build-status/.github/workflows/NightlyBuildsCheck.ymlworkflows.Vendor.ymlshould be triggered only when all builds had succeeded.NightlyBuildsStatus.ymlshould run in any case.So we need to add one more job to
InvokeCI.ymlto createis-successstatus, which istrueonly when all builds had succeeded. Thenis-successstatus should be passed to theNotifyExternalRepositories.ymland its value should be checked before theVendor.ymlworkflow run is called. We should addalways()condition to the "notifying" jobsif:conditions - that makes them not get skipped in case there a builds not succeeded (tested here).