Arena-allocate physical operators #16911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Apr 1, 2025
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Arena-allocate physical operators (duckdb/duckdb#16911)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Arena-allocate physical operators (duckdb/duckdb#16911)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Arena-allocate physical operators (duckdb/duckdb#16911)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Arena-allocate physical operators (duckdb/duckdb#16911)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Arena-allocate physical operators (duckdb/duckdb#16911)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use placement new to arena-allocate the physical operators in the physical plan. This change is another PR in a series of PRs / refactoring to decrease DuckDB's allocation overhead during planning/etc.
Currently, each operator still requires calling its destructor. Ideally, we slowly change this on a per-operator basis with a series of (small) PRs. Thus, this PR introduces a new
PhysicalOperatorMemoryTypeto determine whether we call the respective destructor when destroying the physical plan.