-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add support for time travel syntax in the FROM
clause
#16774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Add support for time travel syntax in the `FROM` clause (duckdb/duckdb#16774)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Add support for time travel syntax in the `FROM` clause (duckdb/duckdb#16774)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add support for time travel syntax in the `FROM` clause (duckdb/duckdb#16774)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Add support for time travel syntax in the `FROM` clause (duckdb/duckdb#16774)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Add support for time travel syntax in the `FROM` clause (duckdb/duckdb#16774)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for time travel syntax in the
FROM
clause, specifically this syntax is now accepted:This is not yet supported in any catalogs, but is pushed into the catalogs using the
EntryLookupInfo
introduced in #16764. Catalogs need to indicate they support this syntax by overloading this method, that defaults to false:The information is passed to the catalog using the
BoundAtClause
:Keyword "AT"
In order to facilitate this in the parser, the keyword
AT
has been moved from unreserved to partially reserved. It can no longer be used a column name/alias without quotes.