Filter Combiner Clean-up: move filter pushdown to separate functions, remove old commented out code #16443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter when pushing down
…of a pushed down filter/expression
|
The regression failure is caused by the IMDB queries in question choosing a different join order because we are no longer duplicating the |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Filter Combiner Clean-up: move filter pushdown to separate functions, remove old commented out code (duckdb/duckdb#16443)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Filter Combiner Clean-up: move filter pushdown to separate functions, remove old commented out code (duckdb/duckdb#16443)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Filter Combiner Clean-up: move filter pushdown to separate functions, remove old commented out code (duckdb/duckdb#16443)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Filter Combiner Clean-up: move filter pushdown to separate functions, remove old commented out code (duckdb/duckdb#16443)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Filter Combiner Clean-up: move filter pushdown to separate functions, remove old commented out code (duckdb/duckdb#16443)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Filter Combiner Clean-up: move filter pushdown to separate functions, remove old commented 608B out code (duckdb/duckdb#16443)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the FilterCombiner:
GenerateTableScanFiltershad been growing, this PR splits the various pieces into separate functions which makes the function much more readableThis shouldn't change functionality with one minor exception: when pushing down a
prefix(col, 'literal')filter, we now remove the originalprefixfilter (since the filter we are pushing down exactly computes the prefix).