8000 [no-op] Remove unused function `GetValueRefUnsafe` by dentiny · Pull Request #16440 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[no-op] Remove unused function GetValueRefUnsafe #16440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

[no-op] Remove unused function GetValueRefUnsafe #16440

merged 1 commit into from
Feb 27, 2025

Conversation

dentiny
Copy link
Contributor
@dentiny dentiny commented Feb 27, 2025 •
edited
Loading

This PR should be a no-op, search through the codebase, I found the function is not used anywhere.

src/include/duckdb/common/types/value.hpp:      T &GetReferenceUnsafe();
src/include/duckdb/storage/statistics/numeric_stats.hpp:                nstats.max.GetReferenceUnsafe<T>() = val;
src/include/duckdb/storage/statistics/numeric_stats.hpp:                nstats.min.GetReferenceUnsafe<T>() = val;
src/include/duckdb/storage/statistics/numeric_stats.hpp:                UpdateValue<T>(new_value, nstats.min.GetReferenceUnsafe<T>(), nstats.max.GetReferenceUnsafe<T>());
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:  T &GetReferenceUnsafe();
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline bool &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline int8_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline int16_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline int32_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline int64_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline hugeint_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline uhugeint_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline uint8_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline uint16_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline uint32_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline uint64_t &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline float &NumericValueUnion::GetReferenceUnsafe() {
src/include/duckdb/storage/statistics/numeric_stats_union.hpp:DUCKDB_API inline double &NumericValueUnion::GetReferenceUnsafe() {

How I tested:

  • I compile the duckdb with CMAKE_BUILD_PARALLEL_LEVEL=$(nproc) make and it compiles without issue
  • For these type of changes, compilation/link success (usually) indicates no problem

@Mytherin Mytherin merged commit d8bff0a into duckdb:main Feb 27, 2025
46 of 47 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@d8bff0a
30881ed 
[no-op] Remove unused function `GetValueRefUnsafe` (duckdb/duckdb#16440)
MAIN_BRANCH_VERSIONING: Add also prefix_version (duckdb/duckdb#16441)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@d8bff0a
feb9100 
[no-op] Remove unused function `GetValueRefUnsafe` (duckdb/duckdb#16440)
MAIN_BRANCH_VERSIONING: Add also prefix_version (duckdb/duckdb#16441)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 16, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@d8bff0a
d664242 
[no-op] Remove unused function `GetValueRefUnsafe` (duckdb/duckdb#16440)
MAIN_BRANCH_VERSIONING: Add also prefix_version (duckdb/duckdb#16441)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@d8bff0a
f6b5037 
[no-op] Remove unused function `GetValueRefUnsafe` (duckdb/duckdb#16440)
MAIN_BRANCH_VERSIONING: Add also prefix_version (duckdb/duckdb#16441)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@d8bff0a
dbd9d7e 
[no-op] Remove unused function `GetValueRefUnsafe` (duckdb/duckdb#16440)
MAIN_BRANCH_VERSIONING: Add also prefix_version (duckdb/duckdb#16441)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@d8bff0a
49f2fda 
[no-op] Remove unused function `GetValueRefUnsafe` (duckdb/duckdb#16440)
MAIN_BRANCH_VERSIONING: Add also prefix_version (duckdb/duckdb#16441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dentiny @Mytherin
0