Linux CLI: override platform for ARM manylinux #16347
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we don't distribute extensions for `linux_arm64_gcc4` flavor, so I think it make little sense to distribute a CLI binary that can't load them. This is not super clean, since then there might be cases where CLI can be launched but extensions load will fail due to a LIBC version mismatch, but I think that's somehow better that no extensions for all. This might need to be reviewed going into v1.3
|
Thanks! |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Mar 4, 2025
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM 8000 manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
docs: tweak explanation of median for even cardinality inputs (duckdb/duckdb#13726) Linux CLI: override platform for ARM manylinux (duckdb/duckdb#16347) [chore] No ccache for OSX Python (duckdb/duckdb#16348) Add missing include (duckdb/duckdb#16342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't distribute extensions for
linux_arm64_gcc4flavor, so I think it make little sense to distribute a CLI binary that can't load them.This is not super clean, since then there might be cases where CLI can be launched but extensions load will fail due to a LIBC version mismatch, but I think that's somehow better that no extensions for all.
This needs to be reviewed going into v1.3, I will add it as task.