Some more Parquet writer performance improvements #16287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Mar 4, 2025
Some more Parquet writer performance improvements (duckdb/duckdb#16287)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Some more Parquet writer performance improvements (duckdb/duckdb#16287)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Some more Parquet writer performance improvements (duckdb/duckdb#16287)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Some more Parquet writer performance improvements (duckdb/duckdb#16287)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Some more Parquet writer performance improvements (duckdb/duckdb#16287)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Some more Parquet writer performance improvements (duckdb/duckdb#16287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #16243. Scraping the bottom of the barrel here, as the previous PR got many of the biggest performance gains already.
This PR adds some more fast paths for when there are no
NULLs, and implements a branchless hash function forstring_t's that are inlined. This required some extra care to make sure that the hash function returns the same value whether the string is inlined or not.Overall, the changes reduce the time it takes to write TPC-H SF10
lineitemto Parquet from ~2.6s to ~2.4s (with the defaultPARQUET_VERSION V1, ~2.5s to ~2.3s withV2).