8000 [Python Dev] Add the correct variant of the `-std=c++11` flag based on the compiler (MSVC or not) by Tishj · Pull Request #16267 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Python Dev] Add the correct variant of the -std=c++11 flag based on the compiler (MSVC or not) #16267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

[Python Dev] Add the correct variant of the -std=c++11 flag based on the compiler (MSVC or not) #16267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
9 changes: 9 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
endif()
endif()

if(${ENABLE_UBSAN})

Check warning on line 206 in CMakeLists.txt

View workflow job for this annotation

GitHub Actions / Windows Extensions (64-bit) 

TIFF support is not enabled and will result in the inability to read some
if(${ENABLE_THREAD_SANITIZER})
message(
WARNING
Expand Down Expand Up @@ -1420,6 +1420,15 @@
set(ALL_COMPILE_FLAGS "${CMAKE_CXX_FLAGS}")
endif()

# Check for MSVC compiler and set the correct C++ standard flag
if(MSVC)
# MSVC does not support `-std=c++11` or `-std=c++14`, use `/std:c++14`
set(ALL_COMPILE_FLAGS "${ALL_COMPILE_FLAGS} /std:c++14")
else()
# For non-MSVC compilers, use the `-std=c++11`
set(ALL_COMPILE_FLAGS "${ALL_COMPILE_FLAGS} -std=c++11")
endif()

get_target_property(duckdb_libs duckdb LINK_LIBRARIES)

set(PIP_COMMAND
Expand Down
Loading
0