Changing mbedtls encryption API #16196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure on Windows is connected to removal of |
2 tasks
Mytherin
added a commit
that referenced
this pull request
Apr 11, 2025
…error` word (#17075) Avoid `git log` while applying patches, that will print a bunch of content to stdout. The stdout then might (or not) contain the word error, interpreted by MSBuild's cmake as an... error. Thanks to the internet, at https://stackoverflow.com/questions/78622876/visual-studio-msbuild-error-msb8066-custom-build and https://developercommunity.visualstudio.com/t/MSBuild:-error:-output-of-custom-build/10554390?sort=newest, and @ccfelius that first raised the problem. Fixes #16177, also reverts #16722. This should unlock #16196 and #16463.
93a9d9f
into
duckdb:main
54 checks passed
<
8000
div class="blankslate-container">
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Changing mbedtls encryption API (duckdb/duckdb#16196)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Changing mbedtls encryption API (duckdb/duckdb#16196)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 19, 2025
Changing mbedtls encryption API (duckdb/duckdb#16196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the mbedtls gcm encryption API (
mbedtls_gcm_xxx) to the general mbedtls encryption API (mbedtls_cipher_xxxx). It also patches the httpfs extension to be compatible with the new function signature of the encryption state.The main reason for replacing the old API with the new one is to be able to support
AES_GCM_CTR_V1for Parquet encryption. I thought it might be better to split this up in two PR's.The change of the encryption API is beneficial such that (i) the mbedtls [en/de]cryption flow is now exactly similar to OpenSSL leading to a single decryption flow in Parquet and (ii) the new API can handle any cipher supported by mbedtls, which is e.g. necessary for supporting
AES_GCM_CTR_V1for Parquet encryption.Note that Windows Extensions is failing in the CI due to the httpfs patch. I have opened an Issue for this (#16177).