8000 Remove bundled TPCH by carlopi · Pull Request #15905 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove bundled TPCH #15905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

Remove bundled TPCH #15905

merged 1 commit into from
Jan 27, 2025

Conversation

carlopi
Copy link
Contributor
@carlopi carlopi commented Jan 24, 2025 •
edited
Loading

Extension loading works, those extensions have been already NOT shipped in some widely used contexts (brew CLI in particular) and it has been fine.

They seems specialised needs that should work without problem via INSTALL / LOAD path used by other extensions.

Also note that autoloading should work out of the box in most situations.

This helps in simplifying the matrix at: https://duckdb.org/docs/extensions/core_extensions#default-extensions, basically after that the rule will become almost everywhere shipping icu, json and parquet.

EDIT: Python wheels to be addressed in a follow up PR.

@Mytherin
Copy link
Collaborator

Thanks!

Inlined python extensions are in tools/pythonpkg/setup.py - we could remove those as well (perhaps as a separate PR?)

@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 24, 2025 20:29
@carlopi carlopi marked this pull request as ready for review January 24, 2025 20:29
@carlopi
Copy link
Contributor Author
carlopi commented Jan 24, 2025

Right, thanks, I pushed also the other change here

@Mytherin
Copy link
Collaborator

I think that part requires some more work to get past CI

@szarnyasg szarnyasg deleted the branch duckdb:v1.2-histrionicus January 25, 2025 11:25
@szarnyasg szarnyasg closed this Jan 25, 2025
@Mytherin Mytherin reopened this Jan 25, 2025
@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 26, 2025 19:34
@carlopi carlopi marked this pull request as ready for review January 26, 2025 19:36
@carlopi
Copy link
Contributor Author
carlopi commented Jan 26, 2025

This should now only be the more trivial part of removing TPCH from bundled extensions. Python on a separate PR.

@carlopi carlopi changed the title Remove bundled TPCH and TPCDS Remove bundled TPCH Jan 26, 2025
@carlopi carlopi mentioned this pull request Jan 27, 2025
Merged
@Mytherin Mytherin merged commit 084126a into duckdb:v1.2-histrionicus Jan 27, 2025
51 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@carlopi carlopi deleted the no_tpch_bundled branch January 27, 2025 09:06
@szarnyasg szarnyasg mentioned this pull request Jan 27, 2025
Closed
2 tasks
Mytherin added a commit that referenced this pull request May 7, 2025
@Mytherin
Remove bundled TPCH & TPCDS in Python wheels (#15923)
9327663 
Same as #15905, removing tpch and
tpcds from duckdb Python wheels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlopi @Mytherin @szarnyasg
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0