Allocator bulk deallocation flush threshold #13796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 11, 2024
Merge pull request duckdb/duckdb#13796 from lnkuiper/allocator_bulk_deallocation_flush_threshold
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 11, 2024
…377) Merge pull request duckdb/duckdb#13796 from lnkuiper/allocator_bulk_deallocation_flush_threshold Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are close to the memory limit and request a large allocation, e.g., for a hash table, we evict and deallocate many small blocks. It may take some time before all of this memory is actually returned to the OS because allocators like jemalloc will keep the memory around for a while. This will cause our RSS to go over the memory limit once we do the large allocation.
This PR implements a threshold parameter that, if the bulk deallocation is larger than the threshold, causes us to flush outstanding unused allocations before such large allocations are actually performed.