8000 SUMMARIZE Not Implemented Error (TIMETZ) · Issue #17115 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SUMMARIZE Not Implemented Error (TIMETZ) #17115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dmcmurchy opened this issue Apr 14, 2025 · 2 comments · Fixed by #17162
Closed
1 of 2 tasks

SUMMARIZE Not Implemented Error (TIMETZ) #17115

dmcmurchy opened this issue Apr 14, 2025 · 2 comments · Fixed by #17162
Labels
reproduced

Comments

@dmcmurchy
Copy link

What happens?

Appears that SUMMARIZE doesn't handle TIMETZ data and generates the following error:

Not implemented Error:
Unimplemented type for cast (INVALID -> DOUBLE)

Additionally, when working with a Jupyter notebook trying to query the table, results in

Not implemented Error: Unsupported type "TIME WITH TIME ZONE"

which initially made me think there was an error with the table but after some digging:

Per @soerenwolfers discussion here

"...is because there is no pandas OR datetime type with the same semantics as DuckDB's TIME WITH TIMEZONE.

If possible, it would be nice to have the pandas related error inform the user that this is due to pandas and perhaps provide a possible workaround.

To Reproduce

Using the CLI:

SUMMARIZE (SELECT '1:02:03.000000+05:30'::TIMETZ);

Gives:

Not implemented Error:
Unimplemented type for cast (INVALID -> DOUBLE)

Using python (example only):

import duckdb
duckdb.query("""SELECT '1:02:03'::TIMETZ""").df()
Not implemented Error: Unsupported type "TIME WITH TIME ZONE"

OS:

x86_64

DuckDB Version:

1.2.2

DuckDB Client:

CLI and python

Hardware:

No response

Full Name:

Dwayne McMurchy

Affiliation:

n/a

What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.

I have not tested with any build

Did you include all relevant data sets for reproducing the issue?

Yes

Did you include all code required to reproduce the issue?

  • Yes, I have

Did you include all relevant configuration (e.g., CPU architecture, Python version, Linux distribution) to reproduce the issue?

  • Yes, I have
@hawkfish
Copy link
Contributor

If this happens in the CLI it has nothing to do with pandas. But I may have messed something up when adding more statistics for temporal types.

@hawkfish
Copy link
Contributor

Yeah I did - the TIMETZ code was never tested and doesn't work. The problem is in approx_quantile

@hawkfish hawkfish mentioned this issue Apr 17, 2025
Merged
hawkfish added a commit to hawkfish/duckdb that referenced this issue Apr 17, 2025
@hawkfish
Issue duckdb#17115: TimeTZ Approximate Quantile
a80c85c 
* Merge with AVG test.

fixes: duckdb#17115
fixes: duckdblabs/duckdb-internal#4669
Mytherin added a commit that referenced this issue Apr 19, 2025
@Mytherin
Issue #17115: TimeTZ Approximate Quantile (#17162)
f85a444 
* Fix implementation to actually work...
* Add tests.

fixes: #17115
fixes: duckdblabs/duckdb-internal#4669
hmeriann pushed a commit to hmeriann/duckdb that referenced this issue Apr 22, 2025
@hawkfish @hmeriann
Issue duckdb#17115: TimeTZ Approximate Quantile
71a0130 
* Fix implementation to actually work...
* Add tests.

fixes: duckdb#17115
fixes: duckdblabs/duckdb-internal#4669
hmeriann pushed a commit to hmeriann/duckdb that referenced this issue Apr 22, 2025
@hawkfish @hmeriann
Issue duckdb#17115: TimeTZ Approximate Quantile
9cb1642 
* Merge with AVG test.

fixes: duckdb#17115
fixes: duckdblabs/duckdb-internal#4669
hmeriann added a commit to hmeriann/duckdb that referenced this issue Apr 22, 2025
@hmeriann
Issue duckdb#17115: TimeTZ Approximate Quantile
8674b09 
* Fix implementation to actually work...
* Add tests.

fixes: duckdb#17115
fixes: duckdblabs/duckdb-internal#4669
hmeriann pushed a commit to hmeriann/duckdb that referenced this issue Apr 22, 2025
@hawkfish @hmeriann
Issue duckdb#17115: TimeTZ Approximate Quantile
c2ca05a 
* Fix implementation to actually work...
* Add tests.

fixes: duckdb#17115
fixes: duckdblabs/duckdb-internal#4669
krlmlr added a commit to duckdb/duckdb-r that referenced this issue May 18, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f85a444
84a6eb4 
Issue duckdb/duckdb#17115: TimeTZ Approximate Quantile (duckdb/duckdb#17162)
krlmlr added a commit to duckdb/duckdb-r that referenced this issue May 18, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f85a444
dd09206 
Issue duckdb/duckdb#17115: TimeTZ Approximate Quantile (duckdb/duckdb#17162)
krlmlr added a commit to duckdb/duckdb-r that referenced this issue May 19, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f85a444
1b9558e 
Issue duckdb/duckdb#17115: TimeTZ Approximate Quantile (duckdb/duckdb#17162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reproduced
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #17115: TimeTZ Approximate Quantile hawkfish/duckdb
4 participants
@szarnyasg @dmcmurchy @hawkfish @duckdblabs-bot
0