add rel external to observablehq links #3941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you point me to the docs for this? I’m curious. |
|
I can't find the official documentation on the VitePress site for this, but they do mention that, for their Markdown extensions, 'Outbound links automatically get target="_blank" rel="noreferrer"'. Looking at the code for VPButton here and VPLink here it does look like they default external links to have |
|
I see, so it’s just that we’re overriding the |
mbostock
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for us to track referrals from d3js.org to observablehq.com, we need to add rel = "external" to the links from Vitepress's buttons and navigation.