Fix URL bug introduced by Apache Update for CVE-2023-25690 #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes URL bugs introduced by Apache Update for CVE-2023-25690 Original commit: https://git.drupalcode.org/project/drupal/-/commit/1df3cfffefefc93ed2d29041d148938d08bb9d4e Note: Original commit changes autocomplete.js, but this change was later reversed for SA-CORE-2020-007 https://git.drupalcode.org/project/drupal/-/commit/cd3721550d988240ef6e682bd1cae2939c6e9e5a#5b6d51049ae7a66f45f48add03d6e3144d037ada
|
@amorsent have you been using this for a longer period of time? How mature would you say is this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #284899: Drupal url problem with clean urls.
https://www.drupal.org/project/drupal/issues/284899
Also fixes URL bugs introduced by Apache Update for CVE-2023-25690
Original commit: https://git.drupalcode.org/project/drupal/-/commit/1df3cfffefefc93ed2d29041d148938d08bb9d4e
Notes:
Test changes from original commit is excluded because the equivalents don't exist in D6.
drupal_environment_initialize()does not exist in D6. I have added the code in_drupal_bootstrap(DRUPAL_BOOTSTRAP_CONFIGURATION)The original commit only syncs $_GET['q']. I am also setting $_REQUEST['q'] 8000 because some contrib modules use that.
Some functions have different names in D6.
drupal_encode_path()isdrupal_urlencode()in D6Drupal.encodePath()isDrupal.encodeURIComponent()in D6The original commit changes autocomplete.js, but this change was later reversed for SA-CORE-2020-007 https://git.drupalcode.org/project/drupal/-/commit/cd3721550d988240ef6e682bd1cae2939c6e9e5a#5b6d51049ae7a66f45f48add03d6e3144d037ada