8000 External link button to link to a component by aperullo · Pull Request #223 · cstate/cstate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

External link button to link to a component #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2022
Merged

External link button to link to a component #223

merged 1 commit into from
Feb 12, 2022

Conversation

aperullo
Copy link
Contributor

Discussion previously occurred in #214

This PR adds a new optional field to components in config.yml for an external url. The intent of this change is to allow cstate administrators to directly link to services/components that have web frontends.

Based on conversation with @mistermantas, the 🔗 unicode character was chosen to represent the link as the only candidate that consistently rendered across all browsers.

Alternatives previously considered:

🡭 U+1F86D
🡵 U+1F875
🢅 U+1F885

Test plan

The change can be enabled or disabled by specifying or omitting the newly added field link. I have enabled it by default for a new component in exampleSite/config.yml to demonstrate its existence to new users.

...
  systems:
    - name: Website
      description: The web frontend for the application.
      category: Uncategorized
      link: https://example.com/

I have tested the change on Linux and verified the chosen character is easily visible in both light and dark mode on the browser I have available. I am requesting a reviewer with a machine with IE please verify the IE8 compatibility, thank you. It also renders correctly in a mobile browser.

light dark
Chrome ✅ ✅
Firefox ✅ ✅
Mac (safari?) ✅ ✅
IE8 ❓ ❓

Documentation changes

Since I cannot include the wiki update as part of the PR, I have included the edited section in this gist.

Closes #214

@aperullo aperullo mentioned this pull request Dec 27, 2021
Closed
@mistermantas
Copy link
Member

Thank you for your excellent contribution and documentation! <3

@mistermantas mistermantas merged commit b17f38d into cstate:dev Feb 12, 2022
@mistermantas mistermantas mentioned this pull request Feb 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aperullo @mistermantas
0