Fix relative date for resolved issues and non-UTC browser timezone. #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their status page is no longer present, as they seem to be changing their web strategy
The missing <UTC> in the layout causes a weird glitch if the users browser is in a non-UTC timezone. For open incidents, the time is rendered as "23-07-2021 12:17:40 UTC", and then the javascript library correctly translates from UTC into the users browser time, resulting in say "30m ago". For a resolved incident, the timezone of the date was stripped due to the missing <UTC> in the format string, resulting in "23-07-2021 12:17:40". If the user has a browser is in the timezone CEST (UTC+2), this causes the relative time to jump from "30 minutes ago" for an open incident to "2 hours ago" for a closed incident, because now the time without time zone is not interpreted as UTC anymore.
|
I'll check this out more in full sometime later cause i might have missed something else in the file too but hope to quickly merge it and release a big fix update after merging |
mistermantas
approved these changes
Jul 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #196 by adding the "UTC" to the partial
small.htmlas it is in the other branch of the if statement.Test plan
I've done the tiny change on our internal status page theme and ran
hugo serve. Times ended up as expected.Closing issues
closes #196