Allow displaying times in users local timezone #157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new config parameter, useLocalTime (defaulted to false for backwards compatibility), which allows rendering dates in a users local timezone instead of UTC.
|
I just realised the similar logic in the "Next Release Dev PR" (#151). I feel like having local times might still be useful but this code is nowhere near as nice as the relative-time logic in that PR, so happy if you want to reject this. If I get time I might try and refactor the code to be a bit nicer. One benefit this PR does have is that the incident-history pages are grouped correctly (ie. when "yearly" or "monthly" is selected) by the users local timezone instead of UTC, but I'm not sure this is really that important compared. |
|
Thanks for your earlier contribution, but I went with the other contribution as it was more versatile this way. Progress - #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new config parameter,
useLocalTime(defaulted tofalsefor backwards compatibility).When set to
true, cState will render all dates in the UI as ISO8601 dates and add some Javascript to update these dates to the users local timezone. This PR ensures the incident history grouping is also done in the users local timezone if enabled.This change only applies to dates rendered in the UI, and not those in the JSON API, these remain in UTC time (though the PR does update the Hugo generation to explicitly use UTC dates).
One downside of altering the dates using Javascript to format the dates is that the
dateFormatandshortDateFormatvariables are no longer useful, as these are in the Golang-specific date format.Before, incident history:
Before, specific incident:
After, incident history (note, I'm in Australia / UTC+10):
After, specific incident:
closes #123