8000 Add prefers-color-scheme dark theme by ethanbarclay · Pull Request #87 · cstate/cstate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add prefers-color-scheme dark theme #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2019
Merged

Add prefers-color-scheme dark theme #87

merged 1 commit into from
Oct 26, 2019

Conversation

ethanbarclay
Copy link
Contributor

Closes #85

@mistermantas
Copy link
Member

Thanks for submitting this. It's a huge help. I'll look thru it as soon as I can, but you should keep in mind that:

  • I only merge into dev. This was made clearer in the dev branch's contributing docs
  • The status colors should, in theory, remain unchanged and use the colors in the config. Yet to see if that would work well tho

@ethanbarclay ethanbarclay changed the base branch from master to dev October 25, 2019 20:02
@ethanbarclay
Copy link
Contributor Author

My bad, didn't see that, I've changed it to merge to dev. I used the colors picked by the extension dark reade. They seem to look better on the dark colors. However I'll remove the color changes if you like.

@mistermantas
Copy link
Member

I’ll merge this because it looks just fine and any adjustments I need can be made later. Thank you so much for contributing, this was a big help!

@mistermantas mistermantas merged commit 9118ff0 into cstate:dev Oct 26, 2019
@mistermantas mistermantas mentioned this pull request Dec 14, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanbarclay @mistermantas
0