8000 Addition of French language by pmdlt · Pull Request #56 · cstate/cstate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Addition of French language #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2019
Merged

Addition of French language #56

merged 3 commits into from
Feb 5, 2019

Conversation

pmdlt
Copy link
Contributor
@pmdlt pmdlt commented Feb 3, 2019

I added the French language.
Can you modify the "Add your translations" documentation?
It seems to me that we need to change static/admin/config.yml and not static/admin/index.html.

Thank you, have a good day.

@mistermantas
Copy link
Member

Thanks a ton!

You’re right, it’s the wrong file. I’ve updated the docs/wiki.

As for the translation itself, do you mind translating/changing the extra strings for v3.1/v4? I’ll paste them here, you should just add them below the v3, like this:

...
- id: newestToOldest
  translation: newest to oldest

##
## v4
##
- id: notFoundAffected
  translation: It looks like this system either does not exist or has never had any recorded downtime.

Also worth noting that the definition of the notFoundText changed and no longer includes the part in the parentheses: (for example, if a system has never been down, we have nothing to show). So it’s just: This could be a problem on our part. Perhaps we moved a certain resource and now it is gone. It is also possible that the resource you are trying to view is empty. But do you also mind to double check the link?

@pmdlt
Copy link
Contributor Author
pmdlt commented Feb 4, 2019

It's done!
Thank you, have a good day.

@mistermantas mistermantas changed the base branch from master to v4.0 February 5, 2019 10:12
6BEC
@mistermantas mistermantas merged commit 752d345 into cstate:v4.0 Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement good first issue priority: med
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmdlt @mistermantas
0