8000 Improve Docker context handling with update and existence check by kammeph · Pull Request #12 · cssnr/stack-deploy-action · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve Docker context handling with update and existence check #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kammeph
Copy link
@kammeph kammeph commented Feb 3, 2025

First, I want to thank you for the work you've put into this GitHub Action.

I encountered some issues with the creation of the Docker context on my self-hosted GitHub Actions runner. It seems like the context might be cached.

In my PR, I first check whether the context exists. If it doesn’t, a new one is created; otherwise, the remote context is updated.

To test this, I forked the repository into the repo where I wanted to use the action and referenced the path to the action in my repository. It worked for me.

Bildschirmfoto 2025-02-03 um 20 50 31

@smashedr
Copy link
Member
smashedr commented Feb 3, 2025

Thank you for the support. I had planned to work on this over the weekend but got busy. So I will review these PR's this week no later than this weekend.

@kammeph
Copy link
Author
kammeph commented Feb 3, 2025

Thanks for your quick response. Let me know if there's anything that can be improved in this PR.

@smashedr
Copy link
Member

I was actually able to reproduce this while working on the other PR. I have included this fix in that PR and will close this one once that PR is merged.

For reference I added 2 stack deploys to the single test job to reproduce it. So this fix will allow deploying multiple stacks in a single job now. Thank you for having this problem solved for me =)

#13

@smashedr smashedr mentioned this pull request Feb 10, 2025
5 tasks
@smashedr
Copy link
Member

I had to include this in my other PR to fix the test.yaml. This has already been merged and released.

https://github.com/cssnr/stack-deploy-action/releases/tag/v1.0.1

Thank you very much for the contribution and support. Please let me know if you run into any more issues...

@smashedr smashedr closed this Feb 11, 2025
@kammeph
Copy link
Author
kammeph commented Feb 12, 2025

I appreciate your work, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0