8000 fix(recordings): handle null maxAge by andrewazores · Pull Request #118 · cryostatio/cryostat-agent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(recordings): handle null maxAge #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2023
Merged

fix(recordings): handle null maxAge #118

merged 3 commits into from
May 5, 2023

Conversation

andrewazores
Copy link
Member

Fixes #117

@andrewazores andrewazores requested a review from ebaron May 5, 2023 20:31
@ebaron ebaron merged commit eb307a8 into cryostatio:main May 5, 2023
mergify bot pushed a commit that referenced this pull request May 5, 2023
@andrewazores @mergify
fix(recordings): handle null maxAge (#118)
08515aa 
* fix(recordings): handle null maxAge

* default to 0, not -1

* handle null startTime in case recording has not yet started

(cherry picked from commit eb307a8)
@mergify mergify bot mentioned this pull request May 5, 2023
Merged
@andrewazores andrewazores deleted the max-age-npe branch May 5, 2023 20:57
ebaron pushed a commit that referenced this pull request May 5, 2023
@mergify @andrewazores
fix(recordings): handle null maxAge (#118) (#119)
b0b6af7 
* fix(recordings): handle null maxAge

* default to 0, not -1

* handle null startTime in case recording has not yet started

(cherry picked from commit eb307a8)

Co-authored-by: Andrew Azores <aazores@redhat.com>
andrewazores added a commit that referenced this pull request May 5, 2023
@andrewazores
fix(recordings): handle null maxAge (#118)
4215e8a 
* fix(recordings): handle null maxAge

* default to 0, not -1

* handle null startTime in case recording has not yet started
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
backport fix
Projects
No open projects
2.3.0 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] SEVERE: recordings serialization failure java.lang.NullPointerException: Cannot invoke "java.time.Duration.toMillis()"
2 participants
@andrewazores @ebaron
0