fix(callback): perform callback resolution within registration loop #635
10000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9f3132 to
7bea227
Compare
ebaron
previously approved these changes
Apr 23, 2025
ebaron
approved these changes
Apr 23, 2025
andrewazores
added a commit
that referenced
this pull request
Apr 23, 2025
andrewazores
added a commit
that referenced
this pull request
Apr 23, 2025
…backport #635) (#638) * fix(callback): perform callback resolution within registration loop (#635) (cherry picked from commit 74d96a4) # Conflicts: # src/main/java/io/cryostat/agent/triggers/TriggerParser.java * fixup! fix(callback): perform callback resolution within registration loop (#635) --------- Co-authored-by: Andrew Azores <me@andrewazor.es> Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #634
Refactors the callback URI resolution from a one-time startup operation (which is always expected to pass, or else startup bails) to a repeatable operation that is done at the beginning of the registration loop. If the DNS resolution fails then the registration loop fails and will repeat on schedule. This accommodates for cases where the Agent (or its host JVM, or the container they're in) may not be able to resolve its own DNS address early in the startup sequence, for example when there are Kubernetes liveness/readiness probes that must first pass before the Pod can be DNS resolved.