8000 fix(signals): handle shutdown signals cleanly on failed startup by andrewazores · Pull Request #44 · cryostatio/cryostat-agent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(signals): handle shutdown signals cleanly on failed startup #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 30, 2023
Merged

fix(signals): handle shutdown signals cleanly on failed startup #44

merged 17 commits into from
Jan 30, 2023

Conversation

andrewazores
Copy link
Member

Fixes #27
Replaces #43

@github-actions
Copy link

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test
8000

@mergify
Copy link
mergify bot commented Jan 26, 2023

⚠️ The sha of the head commit of this PR conflicts with #43. Mergify cannot evaluate rules on this PR. ⚠️

@andrewazores andrewazores mentioned this pull request Jan 26, 2023
Closed
maxcao13
maxcao13 reviewed Jan 27, 2023
View reviewed changes
Copy link
Member
@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those few questions, looks good and the bug is fixed.

@andrewazores andrewazores force-pushed the start-failure-clean-shutdown branch from b11d08f to 709395a Compare January 27, 2023 18:28
maxcao13
maxcao13 reviewed Jan 27, 2023
View reviewed changes
tthvo
tthvo reviewed Jan 30, 2023
View reviewed changes
tthvo
tthvo reviewed Jan 30, 2023
View reviewed changes
tthvo
tthvo reviewed Jan 30, 2023
View reviewed changes
Copy link
Member
@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixed the issue^^ Just some small refactoring and docs comments.

@andrewazores
fix(signals): handle shutdown signals cleanly on failed startup
09090ba
@andrewazores
add config property to replace magic number
aea65fa
@andrewazores
guard against null http which can occur in startup failure
7a026e3
@andrewazores
add Runtime shutdown hook to help ensure clean shutdown
6a93449
@andrewazores
fix null value in log message
9abde09
@andrewazores
fix formatting of comment
0ae942e
@andrewazores
move two config properties under 'webclient' subsection
ad241ca
@andrewazores
extract a magic constant to config
75b8eb4
@andrewazores
fixup! move two config properties under 'webclient' subsection
742127e
@andrewazores
extract fixed constant to config property
3d5081d
@andrewazores
extract max upload timeout to config property
4c0ccbc
@andrewazores
DI object mapper
72d338c
@andrewazores
correct reported default value
3774740
@andrewazores
extract list of handled signals to config property
c23fc32
@andrewazores
set safe ssl defaults
8035c78
@andrewazores
update README
7fca254
@andrewazores
use extract variable ref
e1c5a3b
@andrewazores andrewazores force-pushed the start-failure-clean-shutdown branch from 738cd74 to e1c5a3b Compare January 30, 2023 16:17
tthvo
tthvo approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member
@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :D

@andrewazores andrewazores merged commit ff6c4cd into main Jan 30, 2023
@andrewazores andrewazores deleted the start-failure-clean-shutdown branch January 30, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 left review comments

@tthvo tthvo tthvo approved these changes

Assignees
No one assigned
Labels
fix
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Agent blocks graceful shutdown if it didn't start cleanly
3 participants
@andrewazores @tthvo @maxcao13
0