Add docker image #243
Add docker image #243
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 21 21
Lines 979 979
=======================================
Hits 976 976
Misses 3 3 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@jetexe Thanks for this PR. I would prefer if we only published to ghcr. Would you be okay removing the dockerhub related logic? |
docker/Dockerfile
Outdated
| @@ -0,0 +1,28 @@ | |||
| FROM python:3.11.3-alpine | |||
There was a problem hiding this comment.
Could we switch to the chainguard python images here? https://github.com/chainguard-images/images/tree/main/images/python#usage
There was a problem hiding this comment.
I can't see why a dockerized CLI application needs chainguard images, but I can try to switch. I need more time to experiment.
There was a problem hiding this comment.
@samj1912 there is no git inside cgr.dev/chainguard/python image, but it's required. So what about using cgr.dev/chainguard/python-dev version (since cruft it is a dev tool)
There was a problem hiding this comment.
also need to mention: linux/arm/v6, linux/arm/v7 and linux/386 are not supported by cgr.dev/chainguard/python image
Not a problem. Removed. |
Hi there!
Adding docker images with cruft. This workflow automatically builds docker images with cruft installed and pushes them to
github packagesanddockerhubregistries.You need to create a
dockerhubaccount, create a repository there and setDOCKER_HUB_USERNAMEandDOCKER_HUB_ACCESS_TOKENsecrets in the settings page.Test images was pushed from https://github.com/jetexe/cruft/pull/2 PR:
- DockerhubUsage example:
Closes: #97